t1016: local VAR="VAL" fix
The series was based on maint and fixes all the tests that exist there, but we have acquired a few more. I suspect that the values assigned in many of these places are $IFS safe, and this is primarily to squelch the linter than adding a necessary workaround for buggy dash. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Apr 5, 2024 at 17:28 UTC
836b22139115f92812479ff6a92ffad09f8a6b8c
1 file changed
+6
-6
t/t1016-compatObjectFormat.sh
+6
-6
@@ -79,7 +79,7 @@ commit2_oid () {
79
}
80
81
del_sigcommit () {
82
- local delete=$1
82
+ local delete="$1"
83
84
if test "$delete" = "sha256" ; then
85
local pattern="gpgsig-sha256"
@@ -91,8 +91,8 @@ del_sigcommit () {
91
92
93
del_sigtag () {
94
- local storage=$1
95
- local delete=$2
94
+ local storage="$1"
95
+ local delete="$2"
96
97
if test "$storage" = "$delete" ; then
98
local pattern="trailer"
@@ -181,7 +181,7 @@ done
181
cd "$base"
182
183
compare_oids () {
184
- test "$#" = 5 && { local PREREQ=$1; shift; } || PREREQ=
184
+ test "$#" = 5 && { local PREREQ="$1"; shift; } || PREREQ=
185
local type="$1"
186
local name="$2"
187
local sha1_oid="$3"
@@ -193,8 +193,8 @@ compare_oids () {
193
194
git --git-dir=repo-sha1/.git rev-parse --output-object-format=sha256 ${sha1_oid} > ${name}_sha1_sha256_found
195
git --git-dir=repo-sha256/.git rev-parse --output-object-format=sha1 ${sha256_oid} > ${name}_sha256_sha1_found
196
- local sha1_sha256_oid=$(cat ${name}_sha1_sha256_found)
197
- local sha256_sha1_oid=$(cat ${name}_sha256_sha1_found)
196
+ local sha1_sha256_oid="$(cat ${name}_sha1_sha256_found)"
197
+ local sha256_sha1_oid="$(cat ${name}_sha256_sha1_found)"
198
199
test_expect_success $PREREQ "Verify ${type} ${name}'s sha1 oid" '
200
git --git-dir=repo-sha256/.git rev-parse --output-object-format=sha1 ${sha256_oid} > ${name}_sha1 &&