use labs() for variables of type long instead of abs()
Using abs() on long values can cause truncation, so use labs() instead. Reported by Clang 3.5 (-Wabsolute-value, enabled by -Wall). Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
René Scharfe committed
Nov 15, 2014 at 14:27 UTC
83915ba5219955e8c0b747ec413afe4f78bea289
1 file changed
+2
-2
config.c
+2
-2
@@ -490,9 +490,9 @@ static int git_parse_signed(const char *value, intmax_t *ret, intmax_t max)
490
errno = EINVAL;
491
return 0;
492
}
493
- uval = abs(val);
493
+ uval = labs(val);
494
uval *= factor;
495
- if (uval > max || abs(val) > uval) {
495
+ if (uval > max || labs(val) > uval) {
496
errno = ERANGE;
497
return 0;
498
}