git_config_set: fix off-by-two

Currently, we are slightly overzealous When removing an entry from a config file of this form: [abc]a [xyz] key = value When calling `git config --unset abc.a` on this file, it leaves this (invalid) config behind: [ [xyz] key = value The reason is that we try to search for the beginning of the line (or for the end of the preceding section header on the same line) that defines abc.a, but as an optimization, we subtract 2 from the offset pointing just after the definition before we call find_beginning_of_line(). That function, however, *also* performs that optimization and promptly fails to find the section header correctly. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Schindelin committed Apr 3, 2018 at 18:28 UTC 83b7fd87714c4b70553c56987756ff319ccc7ec6
1 file changed +1 -1
config.c
+1 -1
@@ -2624,7 +2624,7 @@ int git_config_set_multivar_in_file_gently(const char *config_filename,
2624 } else
2625 copy_end = find_beginning_of_line(
2626 contents, contents_sz,
2627 - store.offset[i]-2, &new_line);
2627 + store.offset[i], &new_line);
2628
2629 if (copy_end > 0 && contents[copy_end-1] != '\n')
2630 new_line = 1;