completion: complete more values of more 'color.*' configuration variables

Most 'color.*' configuration variables, with the sole exception of 'color.pager', accept the same set of values, but our completion script recognizes only about half of them. We could explicitly add all those missing variables, but let's try to reduce future maintenance burden, and use the catch-all 'color.*' pattern instead, so this list won't get out of sync when a similar new configuration variable accepting the same values is introduced [1]. Furthermore, their documentation explicitly mentions that they all accept the standard boolean values 'false' and 'true' as well, so list these, too, among the possible values. [1] OTOH, there will be a maintenance burden if ever a new 'color.something' is introduced which doesn't accept the same set of values. We'll see which one happens first... Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

SZEDER Gábor committed Aug 13, 2019 at 14:26 UTC 840d7e5b3ca97f831b5af804a135a9cc79d9b919
1 file changed +4 -5
contrib/completion/git-completion.bash
+4 -5
@@ -2277,11 +2277,6 @@ _git_config ()
2277 __gitcomp "$__git_merge_strategies"
2278 return
2279 ;;
2280 - color.branch|color.diff|color.interactive|\
2281 - color.showbranch|color.status|color.ui)
2282 - __gitcomp "always never auto"
2283 - return
2284 - ;;
2280 color.pager)
2281 __gitcomp "false true"
2282 return
@@ -2293,6 +2288,10 @@ _git_config ()
2288 "
2289 return
2290 ;;
2291 + color.*)
2292 + __gitcomp "false true always never auto"
2293 + return
2294 + ;;
2295 diff.submodule)
2296 __gitcomp "$__git_diff_submodule_formats"
2297 return