configure.ac: improve description of NO_REGEX test
The commit 2f8952250a ("regex: add regexec_buf() that can work on a non NUL-terminated string", 2016-09-21) changed description of NO_REGEX build config variable to be more neutral, and actually say that it is about support for REG_STARTEND. Change description in configure.ac to match. Change also the test message and variable name to match. The test just checks that REG_STARTEND is #defined. Issue-found-by: Ramsay Jones <ramsay@ramsayjones.plus.com> Signed-off-by: Jakub Narębski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jakub Narębski committed
Oct 7, 2016 at 13:30 UTC
842a516cb02a53cf0291ff67ed6f8517966345c0
1 file changed
+7
-6
configure.ac
+7
-6
@@ -835,9 +835,10 @@ AC_CHECK_TYPE([struct addrinfo],[
835
])
836
GIT_CONF_SUBST([NO_IPV6])
837
#
838
-# Define NO_REGEX if you have no or inferior regex support in your C library.
839
-AC_CACHE_CHECK([whether the platform regex can handle null bytes],
840
- [ac_cv_c_excellent_regex], [
838
+# Define NO_REGEX if your C library lacks regex support with REG_STARTEND
839
+# feature.
840
+AC_CACHE_CHECK([whether the platform regex supports REG_STARTEND],
841
+ [ac_cv_c_regex_with_reg_startend], [
842
AC_EGREP_CPP(yippeeyeswehaveit,
843
AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT
844
#include <regex.h>
@@ -846,10 +847,10 @@ AC_EGREP_CPP(yippeeyeswehaveit,
847
yippeeyeswehaveit
848
#endif
849
]),
849
- [ac_cv_c_excellent_regex=yes],
850
- [ac_cv_c_excellent_regex=no])
850
+ [ac_cv_c_regex_with_reg_startend=yes],
851
+ [ac_cv_c_regex_with_reg_startend=no])
852
])
852
-if test $ac_cv_c_excellent_regex = yes; then
853
+if test $ac_cv_c_regex_with_reg_startend = yes; then
854
NO_REGEX=
855
else
856
NO_REGEX=YesPlease