t/t8003-blame-corner-cases.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Jan 8, 2016 at 12:06 UTC
844116d92f822feda5785a2577b232a746ae5307
1 file changed
+2
-2
t/t8003-blame-corner-cases.sh
+2
-2
@@ -153,7 +153,7 @@ test_expect_success 'blame path that used to be a directory' '
153
'
154
155
test_expect_success 'blame to a commit with no author name' '
156
- TREE=`git rev-parse HEAD:` &&
156
+ TREE=$(git rev-parse HEAD:) &&
157
cat >badcommit <<EOF &&
158
tree $TREE
159
author <noname> 1234567890 +0000
@@ -161,7 +161,7 @@ committer David Reiss <dreiss@facebook.com> 1234567890 +0000
161
162
some message
163
EOF
164
- COMMIT=`git hash-object -t commit -w badcommit` &&
164
+ COMMIT=$(git hash-object -t commit -w badcommit) &&
165
git --no-pager blame $COMMIT -- uno >/dev/null
166
'
167