commit-graph: don't call write_graph_chunk_extra_edges() unnecessarily

The optional 'Extra Edge List' chunk of the commit graph file stores parent information for commits with more than two parents. Since the chunk is optional, write_commit_graph() looks through all commits to find those with more than two parents, and then writes the commit graph file header accordingly, i.e. if there are no such commits, then there won't be a 'Extra Edge List' chunk written, only the three mandatory chunks. However, when it later comes to writing actual chunk data, write_commit_graph() unconditionally invokes write_graph_chunk_extra_edges(), even when it was decided earlier that that chunk won't be written. Strictly speaking there is no bug here, because write_graph_chunk_extra_edges() won't write anything if it doesn't find any commits with more than two parents, but then it unnecessarily and in vain looks through all commits once again in search for such commits. Don't call write_graph_chunk_extra_edges() when that chunk won't be written to spare an unnecessary iteration over all commits. Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

SZEDER Gábor committed Jan 23, 2019 at 18:51 UTC 857ba928a4125251f2b4a728ff8021d2adcdbd91
1 file changed +2 -1
commit-graph.c
+2 -1
@@ -946,7 +946,8 @@ void write_commit_graph(const char *obj_dir,
946 write_graph_chunk_fanout(f, commits.list, commits.nr);
947 write_graph_chunk_oids(f, GRAPH_OID_LEN, commits.list, commits.nr);
948 write_graph_chunk_data(f, GRAPH_OID_LEN, commits.list, commits.nr);
949 - write_graph_chunk_extra_edges(f, commits.list, commits.nr);
949 + if (num_extra_edges)
950 + write_graph_chunk_extra_edges(f, commits.list, commits.nr);
951
952 close_commit_graph(the_repository);
953 finalize_hashfile(f, NULL, CSUM_HASH_IN_STREAM | CSUM_FSYNC);