lib-proto-disable: variable name fix
The test_proto function assigns the positional parameters to named variables, but then still refers to "$desc" as "$1". Using $desc is more readable and less error-prone. Signed-off-by: Brandon Williams <bmwill@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Brandon Williams committed
Dec 14, 2016 at 14:39 UTC
85e42053658cf6710b84974be0ef0acf459a80d9
1 file changed
+6
-6
t/lib-proto-disable.sh
+6
-6
@@ -9,7 +9,7 @@ test_proto () {
9
proto=$2
10
url=$3
11
12
- test_expect_success "clone $1 (enabled)" '
12
+ test_expect_success "clone $desc (enabled)" '
13
rm -rf tmp.git &&
14
(
15
GIT_ALLOW_PROTOCOL=$proto &&
@@ -18,7 +18,7 @@ test_proto () {
18
)
19
'
20
21
- test_expect_success "fetch $1 (enabled)" '
21
+ test_expect_success "fetch $desc (enabled)" '
22
(
23
cd tmp.git &&
24
GIT_ALLOW_PROTOCOL=$proto &&
@@ -27,7 +27,7 @@ test_proto () {
27
)
28
'
29
30
- test_expect_success "push $1 (enabled)" '
30
+ test_expect_success "push $desc (enabled)" '
31
(
32
cd tmp.git &&
33
GIT_ALLOW_PROTOCOL=$proto &&
@@ -36,7 +36,7 @@ test_proto () {
36
)
37
'
38
39
- test_expect_success "push $1 (disabled)" '
39
+ test_expect_success "push $desc (disabled)" '
40
(
41
cd tmp.git &&
42
GIT_ALLOW_PROTOCOL=none &&
@@ -45,7 +45,7 @@ test_proto () {
45
)
46
'
47
48
- test_expect_success "fetch $1 (disabled)" '
48
+ test_expect_success "fetch $desc (disabled)" '
49
(
50
cd tmp.git &&
51
GIT_ALLOW_PROTOCOL=none &&
@@ -54,7 +54,7 @@ test_proto () {
54
)
55
'
56
57
- test_expect_success "clone $1 (disabled)" '
57
+ test_expect_success "clone $desc (disabled)" '
58
rm -rf tmp.git &&
59
(
60
GIT_ALLOW_PROTOCOL=none &&