Allow help.htmlpath to be a URL prefix
Setting this to a URL prefix instead of a path to a local directory allows git-help --web to work even when HTML docs aren't locally installed, by pointing the browser at a copy accessible on the web. For example, [help] format = html htmlpath = http://git-scm.com/docs will use the publicly available documentation on the git homepage. Signed-off-by: Chris Webb <chris@arachsys.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Chris Webb committed
Jun 28, 2012 at 07:58 UTC
86272b4ffeb38fb4fb1da3603bba1094fab3731b
1 file changed
+5
-3
builtin/help.c
+5
-3
@@ -395,9 +395,11 @@ static void get_html_page_path(struct strbuf *page_path, const char *page)
395
html_path = system_path(GIT_HTML_PATH);
396
397
/* Check that we have a git documentation directory. */
398
- if (stat(mkpath("%s/git.html", html_path), &st)
399
- || !S_ISREG(st.st_mode))
400
- die(_("'%s': not a documentation directory."), html_path);
398
+ if (!strstr(html_path, "://")) {
399
+ if (stat(mkpath("%s/git.html", html_path), &st)
400
+ || !S_ISREG(st.st_mode))
401
+ die("'%s': not a documentation directory.", html_path);
402
+ }
403
404
strbuf_init(page_path, 0);
405
strbuf_addf(page_path, "%s/%s.html", html_path, page);