commit-graph: remove redundant handling of -h
If we don't handle the -h option here like most parse_options() users we'll fall through and it'll do the right thing for us. I think this code added in 4ce58ee38d (commit-graph: create git-commit-graph builtin, 2018-04-02) was always redundant, parse_options() did this at the time, and the commit-graph code never used PARSE_OPT_NO_INTERNAL_HELP. We don't need a test for this, it's tested by the t0012-help.sh test added in d691551192a (t0012: test "-h" with builtins, 2017-05-30). Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Reviewed-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Aug 23, 2021 at 14:30 UTC
8722f9fb6b7705a3354e2d40d6dba0b86c1dab0d
1 file changed
-4
builtin/commit-graph.c
-4
@@ -321,10 +321,6 @@ int cmd_commit_graph(int argc, const char **argv, const char *prefix)
321
OPT_END(),
322
};
323
324
- if (argc == 2 && !strcmp(argv[1], "-h"))
325
- usage_with_options(builtin_commit_graph_usage,
326
- builtin_commit_graph_options);
327
-
324
git_config(git_default_config, NULL);
325
argc = parse_options(argc, argv, prefix,
326
builtin_commit_graph_options,