protocol-caps.c: fix memory leak in send_info()
Fix a memory leak in a2ba162cda (object-info: support for retrieving object info, 2021-04-20) which appears to have been based on a misunderstanding of how the pkt-line.c API works. There is no need to strdup() input to packet_writer_write(), it's just a printf()-like format function. This fixes a potentially large memory leak, since the number of OID lines the "object-info" call can be arbitrarily large (or a small one if the request is small). This makes t5701-git-serve.sh pass again under SANITIZE=leak, as it did before a2ba162cda2. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Acked-by: Bruno Albuquerque <bga@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Aug 31, 2021 at 15:46 UTC
88682b016dcbdbbdebdd2efd9b7de63e4395636f
1 file changed
+3
-2
protocol-caps.c
+3
-2
@@ -69,9 +69,10 @@ static void send_info(struct repository *r, struct packet_writer *writer,
69
}
70
}
71
72
- packet_writer_write(writer, "%s",
73
- strbuf_detach(&send_buffer, NULL));
72
+ packet_writer_write(writer, "%s", send_buffer.buf);
73
+ strbuf_reset(&send_buffer);
74
}
75
+ strbuf_release(&send_buffer);
76
}
77
78
int cap_object_info(struct repository *r, struct strvec *keys,