test-lib: --valgrind should not override --verbose-log
The --verbose test option cannot be used with test harnesses like "prove". Instead, you must use --verbose-log. Since the --valgrind option implies --verbose, that means that it cannot be used with prove. I.e., this does not work: prove t0000-basic.sh :: --valgrind You'd think it could be fixed by doing: prove t0000-basic.sh :: --valgrind --verbose-log but that doesn't work either, because the implied --verbose takes precedence over --verbose-log. If the user has given us a specific option, we should prefer that. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Sep 5, 2017 at 09:03 UTC
88c6e9d31c695c4500376284a4c3b0e17b665781
1 file changed
+1
-1
t/test-lib.sh
+1
-1
@@ -274,7 +274,7 @@ then
274
test -z "$verbose" && verbose_only="$valgrind_only"
275
elif test -n "$valgrind"
276
then
277
- verbose=t
277
+ test -z "$verbose_log" && verbose=t
278
fi
279
280
if test -n "$color"