date API: create a date.h, split from cache.h
Move the declaration of the date.c functions from cache.h, and adjust the relevant users to include the new date.h header. The show_ident_date() function belonged in pretty.h (it's defined in pretty.c), its two users outside of pretty.c didn't strictly need to include pretty.h, as they get it indirectly, but let's add it to them anyway. Similarly, the change to "builtin/{fast-import,show-branch,tag}.c" isn't needed as far as the compiler is concerned, but since they all use the "DATE_MODE()" macro we now define in date.h, let's have them include it. We could simply include this new header in "cache.h", but as this change shows these functions weren't common enough to warrant including in it in the first place. By moving them out of cache.h changes to this API will no longer cause a (mostly) full re-build of the project when "make" is run. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Feb 16, 2022 at 09:14 UTC
88c7b4c3c8d51510d20ebb9990750ad0e97afbfb
18 files changed
+68
-48
archive-zip.c
+1
@@ -9,6 +9,7 @@
9
#include "object-store.h"
10
#include "userdiff.h"
11
#include "xdiff-interface.h"
12
+#include "date.h"
13
14
static int zip_date;
15
static int zip_time;
builtin/am.c
+1
@@ -34,6 +34,7 @@
34
#include "string-list.h"
35
#include "packfile.h"
36
#include "repository.h"
37
+#include "pretty.h"
38
39
/**
40
* Returns the length of the first line of msg.
builtin/commit.c
+1
@@ -37,6 +37,7 @@
37
#include "help.h"
38
#include "commit-reach.h"
39
#include "commit-graph.h"
40
+#include "pretty.h"
41
42
static const char * const builtin_commit_usage[] = {
43
N_("git commit [<options>] [--] <pathspec>..."),
builtin/fast-import.c
+1
@@ -19,6 +19,7 @@
19
#include "mem-pool.h"
20
#include "commit-reach.h"
21
#include "khash.h"
22
+#include "date.h"
23
24
#define PACK_ID_BITS 16
25
#define MAX_PACK_ID ((1<<PACK_ID_BITS)-1)
builtin/show-branch.c
+1
@@ -8,6 +8,7 @@
8
#include "parse-options.h"
9
#include "dir.h"
10
#include "commit-slab.h"
11
+#include "date.h"
12
13
static const char* show_branch_usage[] = {
14
N_("git show-branch [-a | --all] [-r | --remotes] [--topo-order | --date-order]\n"
builtin/tag.c
+1
@@ -20,6 +20,7 @@
20
#include "oid-array.h"
21
#include "column.h"
22
#include "ref-filter.h"
23
+#include "date.h"
24
25
static const char * const git_tag_usage[] = {
26
N_("git tag [-a | -s | -u <key-id>] [-f] [-m <msg> | -F <file>]\n"
cache.h
-48
@@ -1559,46 +1559,6 @@ struct object *repo_peel_to_type(struct repository *r,
1559
#define peel_to_type(name, namelen, obj, type) \
1560
repo_peel_to_type(the_repository, name, namelen, obj, type)
1561
1562
-enum date_mode_type {
1563
- DATE_NORMAL = 0,
1564
- DATE_HUMAN,
1565
- DATE_RELATIVE,
1566
- DATE_SHORT,
1567
- DATE_ISO8601,
1568
- DATE_ISO8601_STRICT,
1569
- DATE_RFC2822,
1570
- DATE_STRFTIME,
1571
- DATE_RAW,
1572
- DATE_UNIX
1573
-};
1574
-
1575
-struct date_mode {
1576
- enum date_mode_type type;
1577
- const char *strftime_fmt;
1578
- int local;
1579
-};
1580
-
1581
-/*
1582
- * Convenience helper for passing a constant type, like:
1583
- *
1584
- * show_date(t, tz, DATE_MODE(NORMAL));
1585
- */
1586
-#define DATE_MODE(t) date_mode_from_type(DATE_##t)
1587
-struct date_mode *date_mode_from_type(enum date_mode_type type);
1588
-
1589
-const char *show_date(timestamp_t time, int timezone, const struct date_mode *mode);
1590
-void show_date_relative(timestamp_t time, struct strbuf *timebuf);
1591
-int parse_date(const char *date, struct strbuf *out);
1592
-int parse_date_basic(const char *date, timestamp_t *timestamp, int *offset);
1593
-int parse_expiry_date(const char *date, timestamp_t *timestamp);
1594
-void datestamp(struct strbuf *out);
1595
-#define approxidate(s) approxidate_careful((s), NULL)
1596
-timestamp_t approxidate_careful(const char *, int *);
1597
-timestamp_t approxidate_relative(const char *date);
1598
-void parse_date_format(const char *format, struct date_mode *mode);
1599
-int date_overflows(timestamp_t date);
1600
-time_t tm_to_time_t(const struct tm *tm);
1601
-
1562
#define IDENT_STRICT 1
1563
#define IDENT_NO_DATE 2
1564
#define IDENT_NO_NAME 4
@@ -1644,14 +1604,6 @@ struct ident_split {
1604
*/
1605
int split_ident_line(struct ident_split *, const char *, int);
1606
1647
-/*
1648
- * Like show_date, but pull the timestamp and tz parameters from
1649
- * the ident_split. It will also sanity-check the values and produce
1650
- * a well-known sentinel date if they appear bogus.
1651
- */
1652
-const char *show_ident_date(const struct ident_split *id,
1653
- const struct date_mode *mode);
1654
-
1607
/*
1608
* Compare split idents for equality or strict ordering. Note that we
1609
* compare only the ident part of the line, ignoring any timestamp.
config.c
+1
@@ -6,6 +6,7 @@
6
*
7
*/
8
#include "cache.h"
9
+#include "date.h"
10
#include "branch.h"
11
#include "config.h"
12
#include "environment.h"
date.c
+1
@@ -5,6 +5,7 @@
5
*/
6
7
#include "cache.h"
8
+#include "date.h"
9
10
/*
11
* This is like mktime, but without normalization of tm_wday and tm_yday.
date.h
new
+43
@@ -0,0 +1,43 @@
1
+#ifndef DATE_H
2
+#define DATE_H
3
+
4
+enum date_mode_type {
5
+ DATE_NORMAL = 0,
6
+ DATE_HUMAN,
7
+ DATE_RELATIVE,
8
+ DATE_SHORT,
9
+ DATE_ISO8601,
10
+ DATE_ISO8601_STRICT,
11
+ DATE_RFC2822,
12
+ DATE_STRFTIME,
13
+ DATE_RAW,
14
+ DATE_UNIX
15
+};
16
+
17
+struct date_mode {
18
+ enum date_mode_type type;
19
+ const char *strftime_fmt;
20
+ int local;
21
+};
22
+
23
+/*
24
+ * Convenience helper for passing a constant type, like:
25
+ *
26
+ * show_date(t, tz, DATE_MODE(NORMAL));
27
+ */
28
+#define DATE_MODE(t) date_mode_from_type(DATE_##t)
29
+struct date_mode *date_mode_from_type(enum date_mode_type type);
30
+
31
+const char *show_date(timestamp_t time, int timezone, const struct date_mode *mode);
32
+void show_date_relative(timestamp_t time, struct strbuf *timebuf);
33
+int parse_date(const char *date, struct strbuf *out);
34
+int parse_date_basic(const char *date, timestamp_t *timestamp, int *offset);
35
+int parse_expiry_date(const char *date, timestamp_t *timestamp);
36
+void datestamp(struct strbuf *out);
37
+#define approxidate(s) approxidate_careful((s), NULL)
38
+timestamp_t approxidate_careful(const char *, int *);
39
+timestamp_t approxidate_relative(const char *date);
40
+void parse_date_format(const char *format, struct date_mode *mode);
41
+int date_overflows(timestamp_t date);
42
+time_t tm_to_time_t(const struct tm *tm);
43
+#endif
http-backend.c
+1
@@ -13,6 +13,7 @@
13
#include "packfile.h"
14
#include "object-store.h"
15
#include "protocol.h"
16
+#include "date.h"
17
18
static const char content_type[] = "Content-Type";
19
static const char content_length[] = "Content-Length";
ident.c
+1
@@ -7,6 +7,7 @@
7
*/
8
#include "cache.h"
9
#include "config.h"
10
+#include "date.h"
11
12
static struct strbuf git_default_name = STRBUF_INIT;
13
static struct strbuf git_default_email = STRBUF_INIT;
object-name.c
+1
@@ -15,6 +15,7 @@
15
#include "submodule.h"
16
#include "midx.h"
17
#include "commit-reach.h"
18
+#include "date.h"
19
20
static int get_oid_oneline(struct repository *r, const char *, struct object_id *, struct commit_list *);
21
pretty.h
+10
@@ -2,6 +2,7 @@
2
#define PRETTY_H
3
4
#include "cache.h"
5
+#include "date.h"
6
#include "string-list.h"
7
8
struct commit;
@@ -163,4 +164,13 @@ int format_set_trailers_options(struct process_trailer_options *opts,
164
const char **arg,
165
char **invalid_arg);
166
167
+/*
168
+ * Like show_date, but pull the timestamp and tz parameters from
169
+ * the ident_split. It will also sanity-check the values and produce
170
+ * a well-known sentinel date if they appear bogus.
171
+ */
172
+const char *show_ident_date(const struct ident_split *id,
173
+ const struct date_mode *mode);
174
+
175
+
176
#endif /* PRETTY_H */
reflog-walk.h
+1
@@ -5,6 +5,7 @@
5
6
struct commit;
7
struct reflog_walk_info;
8
+struct date_mode;
9
10
void init_reflog_walk(struct reflog_walk_info **info);
11
int add_reflog_for_walk(struct reflog_walk_info *info,
refs.c
+1
@@ -19,6 +19,7 @@
19
#include "strvec.h"
20
#include "repository.h"
21
#include "sigchain.h"
22
+#include "date.h"
23
24
/*
25
* List of all available backends
strbuf.c
+1
@@ -2,6 +2,7 @@
2
#include "refs.h"
3
#include "string-list.h"
4
#include "utf8.h"
5
+#include "date.h"
6
7
int starts_with(const char *str, const char *prefix)
8
{
t/helper/test-date.c
+1
@@ -1,5 +1,6 @@
1
#include "test-tool.h"
2
#include "cache.h"
3
+#include "date.h"
4
5
static const char *usage_msg = "\n"
6
" test-tool date relative [time_t]...\n"