bloom: parse commit before computing filters
When computing changed-path Bloom filters for a commit, we need to know if the commit has a parent or not. If the commit is not parsed, then its parent pointer will be NULL. As far as I can tell, the only opportunity to reach this code without parsing the commit is inside "test-tool bloom get_filter_for_commit" but it is best to be safe. Signed-off-by: Derrick Stolee <dstolee@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Derrick Stolee committed
May 11, 2020 at 11:56 UTC
891c17c95497712126700cdf5cd887bdb0ff3d55
1 file changed
+3
bloom.c
+3
@@ -193,6 +193,9 @@ struct bloom_filter *get_bloom_filter(struct repository *r,
193
diffopt.max_changes = max_changes;
194
diff_setup_done(&diffopt);
195
196
+ /* ensure commit is parsed so we have parent information */
197
+ repo_parse_commit(r, c);
198
+
199
if (c->parents)
200
diff_tree_oid(&c->parents->item->object.oid, &c->object.oid, "", &diffopt);
201
else