fsck: treat a NUL in a tag header as an error
We check the return value of verify_header() for commits already, so do the same for tags as well. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Jeff King <peff@peff.net>
René Scharfe committed
Nov 19, 2015 at 17:25 UTC
8a272f291a34dcc01bad174922de5fd4c9df2cee
2 files changed
+3
-2
fsck.c
+2
-1
@@ -711,7 +711,8 @@ static int fsck_tag_buffer(struct tag *tag, const char *data,
711
}
712
}
713
714
- if (verify_headers(buffer, size, &tag->object, options))
714
+ ret = verify_headers(buffer, size, &tag->object, options);
715
+ if (ret)
716
goto done;
717
718
if (!skip_prefix(buffer, "object ", &buffer)) {
t/t1450-fsck.sh
+1
-1
@@ -288,7 +288,7 @@ test_expect_success 'tag with bad tagger' '
288
grep "error in tag .*: invalid author/committer" out
289
'
290
291
-test_expect_failure 'tag with NUL in header' '
291
+test_expect_success 'tag with NUL in header' '
292
sha=$(git rev-parse HEAD) &&
293
q_to_nul >tag-NUL-header <<-EOF &&
294
object $sha