t/t1401-symbolic-ref.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Dec 22, 2015 at 16:05 UTC
8a7b73c1527c1bcad3230c791b8761a5101abf8d
1 file changed
+1
-1
t/t1401-symbolic-ref.sh
+1
-1
@@ -29,7 +29,7 @@ reset_to_sane
29
30
test_expect_success 'symbolic-ref refuses bare sha1' '
31
echo content >file && git add file && git commit -m one &&
32
- test_must_fail git symbolic-ref HEAD `git rev-parse HEAD`
32
+ test_must_fail git symbolic-ref HEAD $(git rev-parse HEAD)
33
'
34
reset_to_sane
35