@matheusbsbs / matheus-bagliano / commits / 8a83157e04
Fork 0

Reject hexstring longer than 40-bytes in get_short_sha1()

Such a string can never be a valid object name. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <junkio@cox.net>

pclouds@gmail.com committed Oct 19, 2006 at 08:34 UTC 8a83157e04e8f9654b3573cf04276895b1cbd68a
1 file changed +1 -1
sha1_name.c
+1 -1
@@ -157,7 +157,7 @@ static int get_short_sha1(const char *name, int len, unsigned char *sha1,
157 char canonical[40];
158 unsigned char res[20];
159
160 - if (len < MINIMUM_ABBREV)
160 + if (len < MINIMUM_ABBREV || len > 40)
161 return -1;
162 hashclr(res);
163 memset(canonical, 'x', 40);