t3301: test diagnose messages for too few/many paramters
Commit bbb1b8a35a ("notes: check number of parameters to "git notes copy"", 2010-06-28) added a test for too many or too few of parameters provided to `git notes copy'. However, the test only ensures that the command will fail but it doesn't really check if it fails because of number of parameters. If we accidentally lifted the check inside our code base, the test may still have failed because the provided parameter is not a valid ref. Correct it. Signed-off-by: Doan Tran Cong Danh <congdanhqx@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Doan Tran Cong Danh committed
Oct 16, 2019 at 12:18 UTC
8af69cf3e214ee9df3f78bd508465b75881b17a8
1 file changed
+4
-2
t/t3301-notes.sh
+4
-2
@@ -1167,8 +1167,10 @@ test_expect_success 'GIT_NOTES_REWRITE_REF overrides config' '
1167
'
1168
1169
test_expect_success 'git notes copy diagnoses too many or too few parameters' '
1170
- test_must_fail git notes copy &&
1171
- test_must_fail git notes copy one two three
1170
+ test_must_fail git notes copy 2>error &&
1171
+ test_i18ngrep "too few parameters" error &&
1172
+ test_must_fail git notes copy one two three 2>error &&
1173
+ test_i18ngrep "too many parameters" error
1174
'
1175
1176
test_expect_success 'git notes get-ref expands refs/heads/master to refs/notes/refs/heads/master' '