@matheusbsbs / matheus-bagliano / commits / 8bef62049b
Fork 0

Fix spurious compile error

From time to time, I would get this error: [...] sed: -e expression #8, char 41: Unterminated `s' command make: *** [git-add--interactive] Error 1 Turns out that the function WriteMakefile() called in Makefile.PL outputs the message "Writing perl.mak for Git" to stdout! Thus, the output of "make -C perl -s --no-print-directory instlibdir" would be prefixed by that message whenever Makefile.PL was newer than perl.mak. This is fixed by redirecting stdout to stderr in Makefile.PL. Signed-off-by: Johannes E. Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <junkio@cox.net>

Johannes Schindelin committed Jan 16, 2007 at 22:10 UTC 8bef62049b46038334ed6f065fdac27758070a5e
1 file changed +4
perl/Makefile.PL
+4
@@ -20,6 +20,10 @@ if ($@) {
20 my %extra;
21 $extra{DESTDIR} = $ENV{DESTDIR} if $ENV{DESTDIR};
22
23 +# redirect stdout, otherwise the message "Writing perl.mak for Git"
24 +# disrupts the output for the target 'instlibdir'
25 +open STDOUT, ">&STDERR";
26 +
27 WriteMakefile(
28 NAME => 'Git',
29 VERSION_FROM => 'Git.pm',