@matheusbsbs / matheus-bagliano / commits / 8c97e38731

tests: fix version-specific portability issue in Perl JSON

The test guarded by PERLJSON added in 75459410ed ("json_writer: new routines to create JSON data", 2018-07-13) assumed that a JSON boolean value like "true" or "false" would be represented as "1" or "0" in Perl. This behavior can't be relied upon, e.g. with JSON.pm 2.50 and JSON::PP. A JSON::PP::Boolean object will be represented as "true" or "false". To work around this let's check if we have any refs left after we check for hashes and arrays, assume those are JSON objects, and coerce them to a known boolean value. The behavior of this test still looks odd to me. Why implement our own ad-hoc encoder just for some one-off test, as opposed to say Perl's own Data::Dumper with Sortkeys et al? But with this change it works, so let's leave it be. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ævar Arnfjörð Bjarmason committed Aug 24, 2018 at 15:20 UTC 8c97e3873156415015ab41523675416c91914eae
1 file changed +3
t/t0019/parse_json.perl
+3
@@ -34,6 +34,9 @@ sub dump_item {
34 } elsif (ref($value) eq 'HASH') {
35 print "$label_in hash\n";
36 dump_hash($label_in, $value);
37 + } elsif (ref $value) {
38 + my $bool = $value ? 1 : 0;
39 + print "$label_in $bool\n";
40 } elsif (defined $value) {
41 print "$label_in $value\n";
42 } else {