t5541: add 'test_i18ngrep's missing filename parameter
The test 'push --no-progress silences progress but not status' runs 'test_i18ngrep' without specifying a filename parameter. This has remained unnoticed since its introduction in e304aeba2 (t5541: test more combinations of --progress, 2012-05-01), because that 'test_i18ngrep' is supposed to check that the given pattern is not present in its input, and of course it won't find that pattern if its input is empty (as it comes from /dev/null). This also means that this test could miss a potential breakage of 'git push --no-progress'. Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Reviewed-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
SZEDER Gábor committed
Feb 8, 2018 at 16:56 UTC
8cdef01c4282e6006b785a0222589ccd2b65a187
1 file changed
+1
-1
t/t5541-http-push-smart.sh
+1
-1
@@ -234,7 +234,7 @@ test_expect_success TTY 'push --no-progress silences progress but not status' '
234
test_commit no-progress &&
235
test_terminal git push --no-progress >output 2>&1 &&
236
test_i18ngrep "^To http" output &&
237
- test_i18ngrep ! "^Writing objects"
237
+ test_i18ngrep ! "^Writing objects" output
238
'
239
240
test_expect_success 'push --progress shows progress to non-tty' '