builtin/branch.c: remove useless branch_get

branch_get sometimes returns current_branch, which can be NULL (e.g., if you're on a detached HEAD). Try: $ git branch HEAD fatal: no such branch 'HEAD' $ git branch '' fatal: no such branch '' However, it seems weird that we'd check those cases here (and provide such lousy messages). And indeed, dropping that and letting us eventually hit create_branch() gives a much better message: $ git branch HEAD fatal: 'HEAD' is not a valid branch name. $ git branch '' fatal: '' is not a valid branch name. Signed-off-by: Tao Qingyun <taoqy@ls-a.me> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Tao Qingyun committed Oct 16, 2018 at 22:54 UTC 8d2008196b4e6100cf90e8392106e82f46cc1a51
1 file changed -5
builtin/branch.c
-5
@@ -828,11 +828,6 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
828 git_config_set_multivar(buf.buf, NULL, NULL, 1);
829 strbuf_release(&buf);
830 } else if (argc > 0 && argc <= 2) {
831 - struct branch *branch = branch_get(argv[0]);
832 -
833 - if (!branch)
834 - die(_("no such branch '%s'"), argv[0]);
835 -
831 if (filter.kind != FILTER_REFS_BRANCHES)
832 die(_("-a and -r options to 'git branch' do not make sense with a branch name"));
833