t-reftable-merged: improve the const-correctness of helper functions
In t-reftable-merged.c, a number of helper functions used by the tests can be re-defined with parameters made 'const' which makes it easier to understand if they're read-only or not. Re-define these functions along these lines. Mentored-by: Patrick Steinhardt <ps@pks.im> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Chandra Pratap committed
Jul 12, 2024 at 11:09 UTC
8d4f8165d88eb43a4fda8af519936fa194acfbb8
1 file changed
+9
-10
t/unit-tests/t-reftable-merged.c
+9
-10
@@ -15,7 +15,7 @@ https://developers.google.com/open-source/licenses/bsd
15
#include "reftable/reftable-merged.h"
16
#include "reftable/reftable-writer.h"
17
18
-static ssize_t strbuf_add_void(void *b, const void *data, size_t sz)
18
+static ssize_t strbuf_add_void(void *b, const void *data, const size_t sz)
19
{
20
strbuf_add(b, data, sz);
21
return sz;
@@ -27,7 +27,7 @@ static int noop_flush(void *arg)
27
}
28
29
static void write_test_table(struct strbuf *buf,
30
- struct reftable_ref_record refs[], size_t n)
30
+ struct reftable_ref_record refs[], const size_t n)
31
{
32
uint64_t min = 0xffffffff;
33
uint64_t max = 0;
@@ -62,9 +62,8 @@ static void write_test_table(struct strbuf *buf,
62
reftable_writer_free(w);
63
}
64
65
-static void write_test_log_table(struct strbuf *buf,
66
- struct reftable_log_record logs[], size_t n,
67
- uint64_t update_index)
65
+static void write_test_log_table(struct strbuf *buf, struct reftable_log_record logs[],
66
+ const size_t n, const uint64_t update_index)
67
{
68
int err;
69
@@ -90,8 +89,8 @@ static void write_test_log_table(struct strbuf *buf,
89
static struct reftable_merged_table *
90
merged_table_from_records(struct reftable_ref_record **refs,
91
struct reftable_block_source **source,
93
- struct reftable_reader ***readers, size_t *sizes,
94
- struct strbuf *buf, size_t n)
92
+ struct reftable_reader ***readers, const size_t *sizes,
93
+ struct strbuf *buf, const size_t n)
94
{
95
struct reftable_merged_table *mt = NULL;
96
struct reftable_table *tabs;
@@ -116,7 +115,7 @@ merged_table_from_records(struct reftable_ref_record **refs,
115
return mt;
116
}
117
119
-static void readers_destroy(struct reftable_reader **readers, size_t n)
118
+static void readers_destroy(struct reftable_reader **readers, const size_t n)
119
{
120
for (size_t i = 0; i < n; i++)
121
reftable_reader_free(readers[i]);
@@ -267,8 +266,8 @@ static void t_merged_refs(void)
266
static struct reftable_merged_table *
267
merged_table_from_log_records(struct reftable_log_record **logs,
268
struct reftable_block_source **source,
270
- struct reftable_reader ***readers, size_t *sizes,
271
- struct strbuf *buf, size_t n)
269
+ struct reftable_reader ***readers, const size_t *sizes,
270
+ struct strbuf *buf, const size_t n)
271
{
272
struct reftable_merged_table *mt = NULL;
273
struct reftable_table *tabs;