Fix filename scaling for binary files
Set maximum filename length for binary files so that scaling won't be triggered and result in invalid string access. Signed-off-by: Jonas Fonseca <fonseca@diku.dk> Signed-off-by: Junio C Hamano <junkio@cox.net>
Jonas Fonseca committed
Apr 18, 2006 at 23:26 UTC
8d6e10327dff232cc253a5753c43fb414fed4e00
1 file changed
+4
-3
diff.c
+4
-3
@@ -250,13 +250,14 @@ static void show_stats(struct diffstat_t* data)
250
for (i = 0; i < data->nr; i++) {
251
struct diffstat_file *file = data->files[i];
252
253
+ len = strlen(file->name);
254
+ if (max_len < len)
255
+ max_len = len;
256
+
257
if (file->is_binary || file->is_unmerged)
258
continue;
259
if (max_change < file->added + file->deleted)
260
max_change = file->added + file->deleted;
257
- len = strlen(file->name);
258
- if (max_len < len)
259
- max_len = len;
261
}
262
263
for (i = 0; i < data->nr; i++) {