wt-status: use "format" function attribute for status_printf
These functions could benefit from the added compile-time safety of having the compiler check printf arguments. Unfortunately, we also sometimes pass an empty format string, which will cause false positives with -Wformat-zero-length. In this case, that warning is wrong because our function is not a no-op with an empty format: it may be printing colorized output along with a trailing newline. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jul 9, 2013 at 20:23 UTC
8dd0ee823f1829a3aa228c3c73e31de5c89b5317
1 file changed
+4
-4
wt-status.h
+4
-4
@@ -96,9 +96,9 @@ void wt_status_get_state(struct wt_status_state *state, int get_detached_from);
96
void wt_shortstatus_print(struct wt_status *s);
97
void wt_porcelain_print(struct wt_status *s);
98
99
-void status_printf_ln(struct wt_status *s, const char *color, const char *fmt, ...)
100
- ;
101
-void status_printf(struct wt_status *s, const char *color, const char *fmt, ...)
102
- ;
99
+__attribute__((format (printf, 3, 4)))
100
+void status_printf_ln(struct wt_status *s, const char *color, const char *fmt, ...);
101
+__attribute__((format (printf, 3, 4)))
102
+void status_printf(struct wt_status *s, const char *color, const char *fmt, ...);
103
104
#endif /* STATUS_H */