refs: add a generic 'optimize' API
The existing `pack-refs` API is conceptually tied to the 'files' backend, but its behavior is generic (e.g., it triggers compaction for reftable). This naming is confusing. Introduce a new generic refs_optimize() API that dispatches to a backend-specific implementation via a new 'optimize' vtable method. This lays the architectural groundwork for different reference backends (like 'files' and 'reftable') to provide their own storage optimization logic, which will be called from a single, generic entry point. Mentored-by: Patrick Steinhardt <ps@pks.im> Mentored-by: shejialuo <shejialuo@gmail.com> Signed-off-by: Meet Soni <meetsoni3017@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Meet Soni committed
Sep 19, 2025 at 13:56 UTC
8dfe077fb68eb952464ce59deaa4dfdd52891457
3 files changed
+14
refs.c
+5
@@ -2282,6 +2282,11 @@ int refs_pack_refs(struct ref_store *refs, struct pack_refs_opts *opts)
2282
return refs->be->pack_refs(refs, opts);
2283
}
2284
2285
+int refs_optimize(struct ref_store *refs, struct pack_refs_opts *opts)
2286
+{
2287
+ return refs->be->optimize(refs, opts);
2288
+}
2289
+
2290
int peel_iterated_oid(struct repository *r, const struct object_id *base, struct object_id *peeled)
2291
{
2292
if (current_ref_iter &&
refs.h
+6
@@ -480,6 +480,12 @@ struct pack_refs_opts {
480
*/
481
int refs_pack_refs(struct ref_store *refs, struct pack_refs_opts *opts);
482
483
+/*
484
+ * Optimize the ref store. The exact behavior is up to the backend.
485
+ * For the files backend, this is equivalent to packing refs.
486
+ */
487
+int refs_optimize(struct ref_store *refs, struct pack_refs_opts *opts);
488
+
489
/*
490
* Setup reflog before using. Fill in err and return -1 on failure.
491
*/
refs/refs-internal.h
+3
@@ -447,6 +447,8 @@ typedef int ref_transaction_commit_fn(struct ref_store *refs,
447
448
typedef int pack_refs_fn(struct ref_store *ref_store,
449
struct pack_refs_opts *opts);
450
+typedef int optimize_fn(struct ref_store *ref_store,
451
+ struct pack_refs_opts *opts);
452
typedef int rename_ref_fn(struct ref_store *ref_store,
453
const char *oldref, const char *newref,
454
const char *logmsg);
@@ -572,6 +574,7 @@ struct ref_storage_be {
574
ref_transaction_abort_fn *transaction_abort;
575
576
pack_refs_fn *pack_refs;
577
+ optimize_fn *optimize;
578
rename_ref_fn *rename_ref;
579
copy_ref_fn *copy_ref;
580