difftool: remove an unnecessary call to strbuf_release()
The `buf` strbuf is reused again later in the same function, so there is no benefit to calling strbuf_release(). The subsequent usage is already using strbuf_reset() to reset the buffer, so releasing it early is only going to lead to a wasteful reallocation. Remove the early call to strbuf_release(). The same strbuf is already cleaned up in the "finish:" section so nothing is leaked, either. Signed-off-by: David Aguilar <davvid@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
David Aguilar committed
Sep 30, 2021 at 18:37 UTC
8e2af8f0db329a8c0211a309fa9cb611b6dc2517
1 file changed
-2
builtin/difftool.c
-2
@@ -568,8 +568,6 @@ static int run_dir_diff(const char *extcmd, int symlinks, const char *prefix,
568
write_standin_files(entry, &ldir, ldir_len, &rdir, rdir_len);
569
}
570
571
- strbuf_release(&buf);
572
-
571
strbuf_setlen(&ldir, ldir_len);
572
helper_argv[1] = ldir.buf;
573
strbuf_setlen(&rdir, rdir_len);