@matheusbsbs / matheus-bagliano / commits / 8e7110d50c

config: drop `git_config_get_value()` wrapper

In 036876a1067 (config: hide functions using `the_repository` by default, 2024-08-13) we have moved around a bunch of functions in the config subsystem that depend on `the_repository`. Those function have been converted into mere wrappers around their equivalent function that takes in a repository as parameter, and the intent was that we'll eventually remove those wrappers to make the dependency on the global repository variable explicit at the callsite. Follow through with that intent and remove `git_config_get_value()`. All callsites are adjusted so that they use `repo_config_get_value(the_repository, ...)` instead. While some callsites might already have a repository available, this mechanical conversion is the exact same as the current situation and thus cannot cause any regression. Those sites should eventually be cleaned up in a later patch series. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Patrick Steinhardt committed Jul 23, 2025 at 16:08 UTC 8e7110d50cee1ca557d1d79066a2e192b46a1d48

2 files changed +1 -6

config.h

-5

@@ -719,11 +719,6 @@ NORETURN void git_die_config_linenr(const char *key, const char *filename, int l

719 int lookup_config(const char **mapping, int nr_mapping, const char *var);

720

721 # ifdef USE_THE_REPOSITORY_VARIABLE

722 -static inline int git_config_get_value_multi(const char *key, const struct string_list **dest)

723 -{

724 - return repo_config_get_value_multi(the_repository, key, dest);

725 -}

726 -

722 static inline int git_config_get_string_multi(const char *key,

723 const struct string_list **dest)

724 {

t/helper/test-config.c

+1 -1

@@ -121,7 +121,7 @@ int cmd__config(int argc, const char **argv)

121 goto exit1;

122 }

123 } else if (argc == 3 && !strcmp(argv[1], "get_value_multi")) {

124 - if (!git_config_get_value_multi(argv[2], &strptr)) {

124 + if (!repo_config_get_value_multi(the_repository, argv[2], &strptr)) {

125 for (i = 0; i < strptr->nr; i++) {

126 v = strptr->items[i].string;

127 if (!v)