Remove unused assignments
These variables were always overwritten or the assigned value was unused: builtin-diff-tree.c::cmd_diff_tree(): nr_sha1 builtin-for-each-ref.c::opt_parse_sort(): sort_tail builtin-mailinfo.c::decode_header_bq(): in builtin-shortlog.c::insert_one_record(): len connect.c::git_connect(): path imap-send.c::v_issue_imap_cmd(): n pretty.c::pp_user_info(): filler remote::parse_refspec_internal(): llen Signed-off-by: Benjamin Kramer <benny.kra@googlemail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Benjamin Kramer committed
Mar 13, 2009 at 13:51 UTC
8e76bf3fc915ff9c530842123263e7147df207bb
8 files changed
+4
-10
builtin-diff-tree.c
-1
@@ -102,7 +102,6 @@ int cmd_diff_tree(int argc, const char **argv, const char *prefix)
102
103
init_revisions(opt, prefix);
104
git_config(git_diff_basic_config, NULL); /* no "diff" UI options */
105
- nr_sha1 = 0;
105
opt->abbrev = 0;
106
opt->diff = 1;
107
argc = setup_revisions(argc, argv, opt, NULL);
builtin-for-each-ref.c
-1
@@ -943,7 +943,6 @@ static int opt_parse_sort(const struct option *opt, const char *arg, int unset)
943
return -1;
944
945
*sort_tail = s = xcalloc(1, sizeof(*s));
946
- sort_tail = &s->next;
946
947
if (*arg == '-') {
948
s->reverse = 1;
builtin-mailinfo.c
-1
@@ -537,7 +537,6 @@ static int decode_header_bq(struct strbuf *it)
537
*/
538
strbuf_add(&outbuf, in, ep - in);
539
}
540
- in = ep;
540
}
541
/* E.g.
542
* ep : "=?iso-2022-jp?B?GyR...?= foo"
builtin-shortlog.c
-1
@@ -101,7 +101,6 @@ static void insert_one_record(struct shortlog *log,
101
}
102
while (*oneline && isspace(*oneline) && *oneline != '\n')
103
oneline++;
104
- len = eol - oneline;
104
format_subject(&subject, oneline, " ");
105
buffer = strbuf_detach(&subject, NULL);
106
connect.c
+1
-1
@@ -504,7 +504,7 @@ struct child_process *git_connect(int fd[2], const char *url_orig,
504
const char *prog, int flags)
505
{
506
char *url = xstrdup(url_orig);
507
- char *host, *path = url;
507
+ char *host, *path;
508
char *end;
509
int c;
510
struct child_process *conn;
imap-send.c
+1
-1
@@ -579,7 +579,7 @@ static struct imap_cmd *v_issue_imap_cmd(struct imap_store *ctx,
579
n = socket_write(&imap->buf.sock, cmd->cb.data, cmd->cb.dlen);
580
free(cmd->cb.data);
581
if (n != cmd->cb.dlen ||
582
- (n = socket_write(&imap->buf.sock, "\r\n", 2)) != 2) {
582
+ socket_write(&imap->buf.sock, "\r\n", 2) != 2) {
583
free(cmd->cmd);
584
free(cmd);
585
return NULL;
pretty.c
+1
-3
@@ -135,7 +135,6 @@ void pp_user_info(const char *what, enum cmit_fmt fmt, struct strbuf *sb,
135
int namelen;
136
unsigned long time;
137
int tz;
138
- const char *filler = " ";
138
139
if (fmt == CMIT_FMT_ONELINE)
140
return;
@@ -154,7 +153,6 @@ void pp_user_info(const char *what, enum cmit_fmt fmt, struct strbuf *sb,
153
while (line < name_tail && isspace(name_tail[-1]))
154
name_tail--;
155
display_name_length = name_tail - line;
157
- filler = "";
156
strbuf_addstr(sb, "From: ");
157
add_rfc2047(sb, line, display_name_length, encoding);
158
strbuf_add(sb, name_tail, namelen - display_name_length);
@@ -162,7 +160,7 @@ void pp_user_info(const char *what, enum cmit_fmt fmt, struct strbuf *sb,
160
} else {
161
strbuf_addf(sb, "%s: %.*s%.*s\n", what,
162
(fmt == CMIT_FMT_FULLER) ? 4 : 0,
165
- filler, namelen, line);
163
+ " ", namelen, line);
164
}
165
switch (fmt) {
166
case CMIT_FMT_MEDIUM:
remote.c
+1
-1
@@ -495,7 +495,7 @@ static struct refspec *parse_refspec_internal(int nr_refspec, const char **refsp
495
int is_glob;
496
const char *lhs, *rhs;
497
498
- llen = is_glob = 0;
498
+ is_glob = 0;
499
500
lhs = refspec[i];
501
if (*lhs == '+') {