rebase--interactive: avoid empty list in shell for-loop

The $strategy_opts variable contains a space-separated list of strategy options, each individually shell-quoted. To loop over each, we "unwrap" them by doing an eval like: eval ' for opt in '"$strategy_opts"' do ... done ' Note the quoting that means we expand $strategy_opts inline in the code to be evaluated (which is the right thing because we want the IFS-split and de-quoting). If the variable is empty, however, we ask the shell to eval the following code: for opt in do ... done without anything between "in" and "do". Most modern shells are happy to treat that like a noop, but reportedly ksh88 on AIX considers it a syntax error. So let's catch the case that the variable is empty and skip the eval altogether (since we know the loop would be a noop anyway). Reported-by: Armin Kunaschik <megabreit@googlemail.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed May 10, 2016 at 17:07 UTC 8e98b35f87532761f09101729715c2ec49e24ddf
1 file changed +1
git-rebase--interactive.sh
+1
@@ -82,6 +82,7 @@ rewritten_pending="$state_dir"/rewritten-pending
82 cr=$(printf "\015")
83
84 strategy_args=${strategy:+--strategy=$strategy}
85 +test -n "$strategy_opts" &&
86 eval '
87 for strategy_opt in '"$strategy_opts"'
88 do