git-remote-mediawiki: change the name of a variable
Local variable $url has the same name as a global variable. Changing the name of the local variable prevents future possible misunderstanding. Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr> Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Célestin Matte committed
Jun 14, 2013 at 15:50 UTC
8f04f7ddd35331821666f7892c86956b6752de90
1 file changed
+3
-3
contrib/mw-to-git/git-remote-mediawiki.perl
+3
-3
@@ -454,14 +454,14 @@ sub get_mw_mediafile_for_page_revision {
454
}
455
456
sub download_mw_mediafile {
457
- my $url = shift;
457
+ my $download_url = shift;
458
459
- my $response = $mediawiki->{ua}->get($url);
459
+ my $response = $mediawiki->{ua}->get($download_url);
460
if ($response->code == 200) {
461
return $response->decoded_content;
462
} else {
463
print STDERR "Error downloading mediafile from :\n";
464
- print STDERR "URL: $url\n";
464
+ print STDERR "URL: $download_url\n";
465
print STDERR "Server response: " . $response->code . " " . $response->message . "\n";
466
exit 1;
467
}