http-fetch: do not use curl_message after releasing it
When curl_message is released using curl_multi_remove_handle(), it's contents are undefined. Therefore, get the information before releasing it. Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Junio C Hamano <junkio@cox.net>
Johannes Schindelin committed
Nov 7, 2005 at 00:59 UTC
90279074ca5cc336a8bfffd47d19d089b291b432
1 file changed
+3
-3
http-fetch.c
+3
-3
@@ -578,6 +578,7 @@ void process_curl_messages(void)
578
579
while (curl_message != NULL) {
580
if (curl_message->msg == CURLMSG_DONE) {
581
+ int curl_result = curl_message->data.result;
582
slot = active_queue_head;
583
while (slot != NULL &&
584
slot->curl != curl_message->easy_handle)
@@ -587,7 +588,7 @@ void process_curl_messages(void)
588
active_requests--;
589
slot->done = 1;
590
slot->in_use = 0;
590
- slot->curl_result = curl_message->data.result;
591
+ slot->curl_result = curl_result;
592
curl_easy_getinfo(slot->curl,
593
CURLINFO_HTTP_CODE,
594
&slot->http_code);
@@ -599,8 +600,7 @@ void process_curl_messages(void)
600
fprintf(stderr, "Received DONE message for unknown request!\n");
601
}
602
if (request != NULL) {
602
- request->curl_result =
603
- curl_message->data.result;
603
+ request->curl_result = curl_result;
604
request->http_code = slot->http_code;
605
request->slot = NULL;
606
request->state = COMPLETE;