test-lib: handle TEST_OUTPUT_DIRECTORY with spaces
We are careful in test_done to handle a results directory with a space in it, but the "--tee" code path does not. Doing: export TEST_OUTPUT_DIRECTORY='/tmp/path with spaces' ./t000-init.sh --tee results in errors. Let's consistently double-quote our path variables so that this works. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Oct 21, 2016 at 06:42 UTC
925bdc928e3debdc6dbf28b5648711eb1c5583d3
1 file changed
+2
-2
t/test-lib.sh
+2
-2
@@ -58,8 +58,8 @@ done,*)
58
mkdir -p "$TEST_OUTPUT_DIRECTORY/test-results"
59
BASE="$TEST_OUTPUT_DIRECTORY/test-results/$(basename "$0" .sh)"
60
(GIT_TEST_TEE_STARTED=done ${SHELL_PATH} "$0" "$@" 2>&1;
61
- echo $? > $BASE.exit) | tee $BASE.out
62
- test "$(cat $BASE.exit)" = 0
61
+ echo $? >"$BASE.exit") | tee "$BASE.out"
62
+ test "$(cat "$BASE.exit")" = 0
63
exit
64
;;
65
esac