t5563: prevent "ambiguous redirect"
When I ran this test using `TEST_SHELL_PATH=/bin/bash` in my Ubuntu setup (where Bash is at version 5.0.17(1)-release), I was greeted with this error message: ./test-lib.sh: line 1072: $CHALLENGE: ambiguous redirect This commit fixes that error by quoting the `CHALLENGE` variable (which has as value a path containing spaces), and by avoiding to cuddle the empty string parameter in the `printf` call with the redirect character (in fact, the `printf ''>$CHALLENGE` is removed because the next line overwrites the file anyway because it _also_ uses a single `>` to redirect the output). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Schindelin committed
Mar 31, 2023 at 06:52 UTC
92c7b3d473623e25bdc790b89abe8b126eeb3bdf
1 file changed
+12
-14
t/t5563-simple-http-auth.sh
+12
-14
@@ -252,15 +252,14 @@ test_expect_success 'access using basic auth with wwwauth header empty continuat
252
253
# Note that leading and trailing whitespace is important to correctly
254
# simulate a continuation/folded header.
255
- printf "">$CHALLENGE &&
256
- printf "WWW-Authenticate: FooBar param1=\"value1\"\r\n" >$CHALLENGE &&
257
- printf " \r\n" >>$CHALLENGE &&
258
- printf " param2=\"value2\"\r\n" >>$CHALLENGE &&
259
- printf "WWW-Authenticate: Bearer authorize_uri=\"id.example.com\"\r\n" >>$CHALLENGE &&
260
- printf " p=1\r\n" >>$CHALLENGE &&
261
- printf " \r\n" >>$CHALLENGE &&
262
- printf " q=0\r\n" >>$CHALLENGE &&
263
- printf "WWW-Authenticate: Basic realm=\"example.com\"\r\n" >>$CHALLENGE &&
255
+ printf "WWW-Authenticate: FooBar param1=\"value1\"\r\n" >"$CHALLENGE" &&
256
+ printf " \r\n" >>"$CHALLENGE" &&
257
+ printf " param2=\"value2\"\r\n" >>"$CHALLENGE" &&
258
+ printf "WWW-Authenticate: Bearer authorize_uri=\"id.example.com\"\r\n" >>"$CHALLENGE" &&
259
+ printf " p=1\r\n" >>"$CHALLENGE" &&
260
+ printf " \r\n" >>"$CHALLENGE" &&
261
+ printf " q=0\r\n" >>"$CHALLENGE" &&
262
+ printf "WWW-Authenticate: Basic realm=\"example.com\"\r\n" >>"$CHALLENGE" &&
263
264
test_config_global credential.helper test-helper &&
265
git ls-remote "$HTTPD_URL/custom_auth/repo.git" &&
@@ -298,11 +297,10 @@ test_expect_success 'access using basic auth with wwwauth header mixed line-endi
297
298
# Note that leading and trailing whitespace is important to correctly
299
# simulate a continuation/folded header.
301
- printf "">$CHALLENGE &&
302
- printf "WWW-Authenticate: FooBar param1=\"value1\"\r\n" >$CHALLENGE &&
303
- printf " \r\n" >>$CHALLENGE &&
304
- printf "\tparam2=\"value2\"\r\n" >>$CHALLENGE &&
305
- printf "WWW-Authenticate: Basic realm=\"example.com\"" >>$CHALLENGE &&
300
+ printf "WWW-Authenticate: FooBar param1=\"value1\"\r\n" >"$CHALLENGE" &&
301
+ printf " \r\n" >>"$CHALLENGE" &&
302
+ printf "\tparam2=\"value2\"\r\n" >>"$CHALLENGE" &&
303
+ printf "WWW-Authenticate: Basic realm=\"example.com\"" >>"$CHALLENGE" &&
304
305
test_config_global credential.helper test-helper &&
306
git ls-remote "$HTTPD_URL/custom_auth/repo.git" &&