commit-graph: drop redundant call to "lite" verification
The idea of verify_commit_graph_lite() is to have cheap verification checks both for everyday use of the graph files (to avoid out of bounds reads, etc) as well as for doing a full check via "commit-graph verify" (which will also check the hash, etc). But the expensive verification checks operate on a commit_graph struct, which we get by using the normal everyday-reader code! So any problem we'd find by calling it would have been found before we even got to the verify_one_commit_graph() function. Removing it simplifies the code a bit, but also frees us up to move the "lite" verification steps around within that everyday-reader code. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Nov 9, 2023 at 02:13 UTC
92de4c5d56d084325997ca057701b65a9e79276a
1 file changed
-4
commit-graph.c
-4
@@ -2690,10 +2690,6 @@ static int verify_one_commit_graph(struct repository *r,
2690
struct commit *seen_gen_zero = NULL;
2691
struct commit *seen_gen_non_zero = NULL;
2692
2693
- verify_commit_graph_error = verify_commit_graph_lite(g);
2694
- if (verify_commit_graph_error)
2695
- return verify_commit_graph_error;
2696
-
2693
if (!commit_graph_checksum_valid(g)) {
2694
graph_report(_("the commit-graph file has incorrect checksum and is likely corrupt"));
2695
verify_commit_graph_error = VERIFY_COMMIT_GRAPH_ERROR_HASH;