difftool: hack around -Wzero-length-format warning
Building with "gcc -Wall" will complain that the format in: warning("") is empty. Which is true, but the warning is over-eager. We are calling the function for its side effect of printing "warning:", even with an empty string. Our DEVELOPER Makefile knob disables the warning, but not everybody uses it. Let's silence the warning in the code so that nobody reports it or tries to "fix" it. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jan 25, 2017 at 13:35 UTC
94d3997ecc09f36d17b9ad4b49c4709885e300f7
1 file changed
+1
-1
builtin/difftool.c
+1
-1
@@ -567,7 +567,7 @@ static int run_dir_diff(const char *extcmd, int symlinks, const char *prefix,
567
warning(_("both files modified: '%s' and '%s'."),
568
wtdir.buf, rdir.buf);
569
warning(_("working tree file has been left."));
570
- warning("");
570
+ warning("%s", "");
571
err = 1;
572
} else if (unlink(wtdir.buf) ||
573
copy_file(wtdir.buf, rdir.buf, st.st_mode))