@matheusbsbs / matheus-bagliano / commits / 950079b7b6

t/chainlint: add chainlint "specialized" test cases

The --chain-lint option uses heuristics and knowledge of shell syntax to detect broken &&-chains in subshells by pure textual inspection. The heuristics handle a range of stylistic variations in existing tests (evolved over the years), however, they are still best-guesses. As such, it is possible for future changes to accidentally break assumptions upon which the heuristics are based. Protect against this possibility by adding tests which check the linter itself for correctness. In addition to protecting against regressions, these tests help document (for humans) expected behavior, which is important since the linter's implementation language ('sed') does not necessarily lend itself to easy comprehension. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Eric Sunshine committed Jul 11, 2018 at 02:46 UTC 950079b7b6342309059c8c0f9e7340f43e82bf93

4 files changed +31

t/chainlint/bash-array.expect new

+10

@@ -0,0 +1,10 @@

1 +(

2 + foo &&

3 + bar=(gumbo stumbo wumbo) &&

4 + baz

5 +>) &&

6 +(

7 + foo &&

8 + bar=${#bar[@]} &&

9 + baz

10 +>)

t/chainlint/bash-array.test new

+12

@@ -0,0 +1,12 @@

1 +(

2 + foo &&

3 +# LINT: ")" in Bash array assignment not misinterpreted as subshell-closing ")"

4 + bar=(gumbo stumbo wumbo) &&

5 + baz

6 +) &&

7 +(

8 + foo &&

9 +# LINT: Bash array length operator not misinterpreted as comment

10 + bar=${#bar[@]} &&

11 + baz

12 +)

t/chainlint/p4-filespec.expect new

@@ -0,0 +1,4 @@

1 +(

2 + p4 print -1 //depot/fiddle#42 >file &&

3 + foobar

4 +>)

t/chainlint/p4-filespec.test new

@@ -0,0 +1,5 @@

1 +(

2 +# LINT: Perforce revspec in filespec not misinterpreted as in-line comment

3 + p4 print -1 //depot/fiddle#42 >file &&

4 + foobar

5 +)