t5410: test receive-pack connectivity check

As part of git-recieve-pack(1), the connectivity of objects is checked. Add a test validating that git-receive-pack(1) fails due to an incoming packfile that would leave the repository with missing objects. Instead of creating a new test file, "t5410" is generalized for receive-pack testing. Signed-off-by: Justin Tobler <jltobler@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Justin Tobler committed May 20, 2025 at 11:32 UTC 95262afe788e0b6b4ae5ff37e8d28fb5883c1a82
2 files changed +23 -2
t/meson.build
+1 -1
@@ -629,7 +629,7 @@ integration_tests = [
629 't5407-post-rewrite-hook.sh',
630 't5408-send-pack-stdin.sh',
631 't5409-colorize-remote-messages.sh',
632 - 't5410-receive-pack-alternates.sh',
632 + 't5410-receive-pack.sh',
633 't5411-proc-receive-hook.sh',
634 't5500-fetch-pack.sh',
635 't5501-fetch-push-alternates.sh',
t/t5410-receive-pack.sh renamed
+22 -1
@@ -1,6 +1,6 @@
1 #!/bin/sh
2
3 -test_description='git receive-pack with alternate ref filtering'
3 +test_description='git receive-pack'
4
5 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
6 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
@@ -41,4 +41,25 @@ test_expect_success 'with core.alternateRefsPrefixes' '
41 test_cmp expect actual.haves
42 '
43
44 +test_expect_success 'receive-pack missing objects fails connectivity check' '
45 + test_when_finished rm -rf repo remote.git setup.git &&
46 +
47 + git init repo &&
48 + git -C repo commit --allow-empty -m 1 &&
49 + git clone --bare repo setup.git &&
50 + git -C repo commit --allow-empty -m 2 &&
51 +
52 + # Capture git-send-pack(1) output sent to git-receive-pack(1).
53 + git -C repo send-pack ../setup.git --all \
54 + --receive-pack="tee ${SQ}$(pwd)/out${SQ} | git-receive-pack" &&
55 +
56 + # Replay captured git-send-pack(1) output on new empty repository.
57 + git init --bare remote.git &&
58 + git receive-pack remote.git <out >actual 2>err &&
59 +
60 + test_grep "missing necessary objects" actual &&
61 + test_grep "fatal: Failed to traverse parents" err &&
62 + test_must_fail git -C remote.git cat-file -e $(git -C repo rev-parse HEAD)
63 +'
64 +
65 test_done