contrib/vscode/: debugging with VS Code and gdb

The externalConsole=true setting is broken for many users (launching the debugger with such setting results in VS Code waiting forever without actually starting the debugger). Also, this setting is a matter of user preference, and is arguably better set in a "launch" section in the user-wide settings.json than hardcoded in our script. Remove the line to use VS Code's default, or the user's setting. Add useful links in contrib/vscode/README.md to help the user to configure VS Code and how to use the debugging feature. Helped-by: Matthieu Moy <Matthieu.Moy@univ-lyon1.fr> Helped-by: Derrick Stolee <derrickstolee@github.com> Co-authored-by: BRESSAT Jonathan <git.jonathan.bressat@gmail.com> Signed-off-by: COGONI Guillaume <cogoni.guillaume@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

COGONI Guillaume committed Apr 7, 2022 at 22:40 UTC 95b3002201384d6b1de5d1243aba45e1f5065c23
2 files changed +5 -2
contrib/vscode/README.md
+5 -1
@@ -6,7 +6,11 @@ code editor which runs on your desktop and is available for
6 [Windows](https://code.visualstudio.com/docs/setup/windows),
7 [macOS](https://code.visualstudio.com/docs/setup/mac) and
8 [Linux](https://code.visualstudio.com/docs/setup/linux). Among other languages,
9 -it has [support for C/C++ via an extension](https://github.com/Microsoft/vscode-cpptools).
9 +it has [support for C/C++ via an extension](https://github.com/Microsoft/vscode-cpptools) with
10 +[debugging support](https://code.visualstudio.com/docs/editor/debugging)
11 +
12 +To get help about "how to personalize your settings" read:
13 +[How to set up your settings](https://code.visualstudio.com/docs/getstarted/settings)
14
15 To start developing Git with VS Code, simply run the Unix shell script called
16 `init.sh` in this directory, which creates the configuration files in
contrib/vscode/init.sh
-1
@@ -271,7 +271,6 @@ cat >.vscode/launch.json.new <<EOF ||
271 "stopAtEntry": false,
272 "cwd": "\${workspaceFolder}",
273 "environment": [],
274 - "externalConsole": true,
274 "MIMode": "gdb",
275 "miDebuggerPath": "$GDBPATH",
276 "setupCommands": [