clone: forbid --bare --separate-git-dir <dir>

The --separate-git-dir option was introduced to make it simple to put the git directory somewhere outside the worktree, for example when cloning a repository for use as a submodule. It was not intended for use when creating a bare repository. In that case there is no worktree and it is more natural to directly clone the repository and create a .git file as separate steps: git clone --bare /path/to/repo.git bar.git printf 'gitdir: bar.git\n' >foo.git Forbid the combination, making the command easier to explain. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Nguyễn Thái Ngọc Duy committed Jan 11, 2013 at 10:09 UTC 95b63f1ebb1d2b1ae34238cac331dd1e6e437975
1 file changed +2
builtin/clone.c
+2
@@ -704,6 +704,8 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
704 if (option_origin)
705 die(_("--bare and --origin %s options are incompatible."),
706 option_origin);
707 + if (real_git_dir)
708 + die(_("--bare and --separate-git-dir are incompatible."));
709 option_no_checkout = 1;
710 }
711