commit-reach: fix index used to loop through unsigned integer
In 62e745ced2 (prio-queue: use size_t rather than int for size, 2024-12-20), we refactored `struct prio_queue` to track the number of contained entries via a `size_t`. While the refactoring adapted one of the users of that variable, it forgot to also adapt "commit-reach.c" accordingly. This was missed because that file has -Wsign-conversion disabled. Fix the issue by using a `size_t` to iterate through entries. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Patrick Steinhardt committed
Dec 27, 2024 at 11:46 UTC
95c09e4d07492fa9e4ad951a268b4ea6bae69038
1 file changed
+1
-2
commit-reach.c
+1
-2
@@ -42,8 +42,7 @@ static int compare_commits_by_gen(const void *_a, const void *_b)
42
43
static int queue_has_nonstale(struct prio_queue *queue)
44
{
45
- int i;
46
- for (i = 0; i < queue->nr; i++) {
45
+ for (size_t i = 0; i < queue->nr; i++) {
46
struct commit *commit = queue->array[i].data;
47
if (!(commit->object.flags & STALE))
48
return 1;