tests --valgrind: provide a mode without --track-origins
With --valgrind=memcheck-fast, the tests run under memcheck but without the autodetected --track-origins. If you just run valgrind to see *if* there is any memory issue with your program, the extra information is not needed, and it comes at a roughly 30% hit in runtime. While it is possible to achieve the same through GIT_VALGRIND_OPTIONS, this should be more discoverable and hopefully encourage more users to run their tests with valgrind. Signed-off-by: Thomas Rast <trast@inf.ethz.ch> Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Thomas Rast committed
Mar 31, 2013 at 10:00 UTC
95d9d5ec75d3549f00cac29cd33be899cfb4693a
2 files changed
+7
t/README
+5
@@ -106,6 +106,11 @@ appropriately before running "make".
106
'drd', but you may use any tool recognized by your valgrind
107
installation.
108
109
+ As a special case, <tool> can be 'memcheck-fast', which uses
110
+ memcheck but disables --track-origins. Use this if you are
111
+ running tests in bulk, to see if there are _any_ memory
112
+ issues.
113
+
114
Note that memcheck is run with the option --leak-check=no,
115
as the git process is short-lived and some errors are not
116
interesting. In order to run a single command under the same
t/valgrind/valgrind.sh
+2
@@ -5,6 +5,8 @@ base=$(basename "$0")
5
TOOL_OPTIONS='--leak-check=no'
6
7
case "$GIT_VALGRIND_MODE" in
8
+memcheck-fast)
9
+ ;;
10
memcheck)
11
VALGRIND_VERSION=$(valgrind --version)
12
VALGRIND_MAJOR=$(expr "$VALGRIND_VERSION" : '[^0-9]*\([0-9]*\)')