refspec: make sure stack refspec_item variables are zeroed

A couple of functions that used struct refspec_item did not zero out the structure memory. This can result in unexpected behavior, especially if additional parameters are ever added to refspec_item in the future. Use memset to ensure that unset structure members are zero. It may make sense to convert most of these uses of struct refspec_item to use either struct initializers or refspec_item_init_or_die. However, other similar code uses memset. Converting all of these uses has been left as a future exercise. Signed-off-by: Jacob Keller <jacob.keller@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jacob Keller committed Aug 14, 2020 at 17:25 UTC 95e7c385393488cb20c29697d8655f94ce83c413

2 files changed +2

builtin/remote.c

@@ -478,6 +478,7 @@ static int get_head_names(const struct ref *remote_refs, struct ref_states *stat

478 struct ref *fetch_map = NULL, **fetch_map_tail = &fetch_map;

479 struct refspec_item refspec;

480

481 + memset(&refspec, 0, sizeof(refspec));

482 refspec.force = 0;

483 refspec.pattern = 1;

484 refspec.src = refspec.dst = "refs/heads/*";

transport.c

@@ -443,6 +443,7 @@ void transport_update_tracking_ref(struct remote *remote, struct ref *ref, int v

443 if (ref->status != REF_STATUS_OK && ref->status != REF_STATUS_UPTODATE)

444 return;

445

446 + memset(&rs, 0, sizeof(rs));

447 rs.src = ref->name;

448 rs.dst = NULL;

449