subtree: make "all" default target of Makefile
You should be able to run "make" in contrib/subtree with no arguments and get the "all" target. This was broken by 8e2a5cc (contrib/subtree/Makefile: use GIT-VERSION-FILE, 2014-05-06), which put the rule for GIT-VERSION-FILE higher in the file. We can fix this by putting an empty "all::" target at the top of the file, just like our main Makefile does, and document that fact. That fixes this instance and future-proofs against it happening again. Reported-by: Jack Nagel <jacknagel@gmail.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Aug 17, 2014 at 03:07 UTC
960160b061a29a4a4ae637e035c3892da72326ac
1 file changed
+4
-1
contrib/subtree/Makefile
+4
-1
@@ -1,3 +1,6 @@
1
+# The default target of this Makefile is...
2
+all::
3
+
4
-include ../../config.mak.autogen
5
-include ../../config.mak
6
@@ -34,7 +37,7 @@ GIT_SUBTREE_XML := git-subtree.xml
37
GIT_SUBTREE_TXT := git-subtree.txt
38
GIT_SUBTREE_HTML := git-subtree.html
39
37
-all: $(GIT_SUBTREE)
40
+all:: $(GIT_SUBTREE)
41
42
$(GIT_SUBTREE): $(GIT_SUBTREE_SH)
43
sed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' $< >$@