pack-bitmap-write: drop unused pack_idx_entry parameters
Our write_selected_commits_v1() function takes an array of pack_idx_entry structs. We used to need them for computing commit positions, but since aa30162559 (bitmap: move `get commit positions` code to `bitmap_writer_finish`, 2022-08-14), the caller passes in a separate array of positions for us. We can drop the unused array (and its matching length parameter). Likewise, when we added write_lookup_table() in 93eb41e240 (pack-bitmap-write.c: write lookup table extension, 2022-08-14), it receives the same array of positions. So its "index" parameter was never used at all. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Aug 28, 2022 at 08:50 UTC
969a5645876ccf368ed74fde2c5dc9b5432b7bb0
1 file changed
+2
-6
pack-bitmap-write.c
+2
-6
@@ -649,8 +649,6 @@ static const struct object_id *oid_access(size_t pos, const void *table)
649
}
650
651
static void write_selected_commits_v1(struct hashfile *f,
652
- struct pack_idx_entry **index,
653
- uint32_t index_nr,
652
uint32_t *commit_positions,
653
off_t *offsets)
654
{
@@ -685,8 +683,6 @@ static int table_cmp(const void *_va, const void *_vb, void *_data)
683
}
684
685
static void write_lookup_table(struct hashfile *f,
688
- struct pack_idx_entry **index,
689
- uint32_t index_nr,
686
uint32_t *commit_positions,
687
off_t *offsets)
688
{
@@ -808,10 +804,10 @@ void bitmap_writer_finish(struct pack_idx_entry **index,
804
commit_positions[i] = commit_pos;
805
}
806
811
- write_selected_commits_v1(f, index, index_nr, commit_positions, offsets);
807
+ write_selected_commits_v1(f, commit_positions, offsets);
808
809
if (options & BITMAP_OPT_LOOKUP_TABLE)
814
- write_lookup_table(f, index, index_nr, commit_positions, offsets);
810
+ write_lookup_table(f, commit_positions, offsets);
811
812
if (options & BITMAP_OPT_HASH_CACHE)
813
write_hash_cache(f, index, index_nr);