pkt-line: fix packet_read_line() to handle len < 0 errors
Update packet_read_line() to test for len > 0 to avoid potential bug if read functions return lengths less than zero to indicate errors. Signed-off-by: Ben Peart <benpeart@microsoft.com> Found/Fixed-by: Lars Schneider <larsxschneider@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ben Peart committed
May 5, 2017 at 11:27 UTC
974b50c5565107e1e3209176682ee6f6e420bd2b
1 file changed
+1
-1
pkt-line.c
+1
-1
@@ -315,7 +315,7 @@ static char *packet_read_line_generic(int fd,
315
PACKET_READ_CHOMP_NEWLINE);
316
if (dst_len)
317
*dst_len = len;
318
- return len ? packet_buffer : NULL;
318
+ return (len > 0) ? packet_buffer : NULL;
319
}
320
321
char *packet_read_line(int fd, int *len_p)