t1430: create valid symrefs using test-helper
This still leaves some other direct filesystem access. Currently, the files backend does not allow invalidly named symrefs. Fixes for this are currently in the 'seen' branch Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Han-Wen Nienhuys committed
Dec 7, 2021 at 13:38 UTC
9912391402ad1b910c6d712565553d7e5b22d7e1
1 file changed
+6
-8
t/t1430-bad-ref-name.sh
+6
-8
@@ -153,7 +153,7 @@ test_expect_success 'rev-parse skips symref pointing to broken name' '
153
test_when_finished "test-tool ref-store main delete-refs REF_NO_DEREF msg refs/heads/broken...ref" &&
154
git branch shadow one &&
155
test-tool ref-store main update-ref msg "refs/heads/broken...ref" $main_sha1 $ZERO_OID REF_SKIP_REFNAME_VERIFICATION &&
156
- printf "ref: refs/heads/broken...ref\n" >.git/refs/tags/shadow &&
156
+ test-tool ref-store main create-symref refs/tags/shadow refs/heads/broken...ref msg &&
157
test_when_finished "test-tool ref-store main delete-refs REF_NO_DEREF msg refs/tags/shadow" &&
158
git rev-parse --verify one >expect &&
159
git rev-parse --verify shadow >actual 2>err &&
@@ -203,7 +203,7 @@ test_expect_success 'update-ref --no-deref -d can delete symref to broken name'
203
test-tool ref-store main update-ref msg "refs/heads/broken...ref" $main_sha1 $ZERO_OID REF_SKIP_REFNAME_VERIFICATION &&
204
205
test_when_finished "test-tool ref-store main delete-refs REF_NO_DEREF msg refs/heads/broken...ref" &&
206
- printf "ref: refs/heads/broken...ref\n" >.git/refs/heads/badname &&
206
+ test-tool ref-store main create-symref refs/heads/badname refs/heads/broken...ref msg &&
207
test_when_finished "test-tool ref-store main delete-refs REF_NO_DEREF msg refs/heads/badname" &&
208
git update-ref --no-deref -d refs/heads/badname >output 2>error &&
209
test_path_is_missing .git/refs/heads/badname &&
@@ -213,9 +213,8 @@ test_expect_success 'update-ref --no-deref -d can delete symref to broken name'
213
214
test_expect_success 'branch -d can delete symref to broken name' '
215
test-tool ref-store main update-ref msg "refs/heads/broken...ref" $main_sha1 $ZERO_OID REF_SKIP_REFNAME_VERIFICATION &&
216
-
216
test_when_finished "test-tool ref-store main delete-refs REF_NO_DEREF msg refs/heads/broken...ref" &&
218
- printf "ref: refs/heads/broken...ref\n" >.git/refs/heads/badname &&
217
+ test-tool ref-store main create-symref refs/heads/badname refs/heads/broken...ref msg &&
218
test_when_finished "test-tool ref-store main delete-refs REF_NO_DEREF msg refs/heads/badname" &&
219
git branch -d badname >output 2>error &&
220
test_path_is_missing .git/refs/heads/badname &&
@@ -224,7 +223,7 @@ test_expect_success 'branch -d can delete symref to broken name' '
223
'
224
225
test_expect_success 'update-ref --no-deref -d can delete dangling symref to broken name' '
227
- printf "ref: refs/heads/broken...ref\n" >.git/refs/heads/badname &&
226
+ test-tool ref-store main create-symref refs/heads/badname refs/heads/broken...ref msg &&
227
test_when_finished "test-tool ref-store main delete-refs REF_NO_DEREF msg refs/heads/badname" &&
228
git update-ref --no-deref -d refs/heads/badname >output 2>error &&
229
test_path_is_missing .git/refs/heads/badname &&
@@ -233,7 +232,7 @@ test_expect_success 'update-ref --no-deref -d can delete dangling symref to brok
232
'
233
234
test_expect_success 'branch -d can delete dangling symref to broken name' '
236
- printf "ref: refs/heads/broken...ref\n" >.git/refs/heads/badname &&
235
+ test-tool ref-store main create-symref refs/heads/badname refs/heads/broken...ref msg &&
236
test_when_finished "test-tool ref-store main delete-refs REF_NO_DEREF msg refs/heads/badname" &&
237
git branch -d badname >output 2>error &&
238
test_path_is_missing .git/refs/heads/badname &&
@@ -243,9 +242,8 @@ test_expect_success 'branch -d can delete dangling symref to broken name' '
242
243
test_expect_success 'update-ref -d can delete broken name through symref' '
244
test-tool ref-store main update-ref msg "refs/heads/broken...ref" $main_sha1 $ZERO_OID REF_SKIP_REFNAME_VERIFICATION &&
246
-
245
test_when_finished "test-tool ref-store main delete-refs REF_NO_DEREF msg refs/heads/broken...ref" &&
248
- printf "ref: refs/heads/broken...ref\n" >.git/refs/heads/badname &&
246
+ test-tool ref-store main create-symref refs/heads/badname refs/heads/broken...ref msg &&
247
test_when_finished "test-tool ref-store main delete-refs REF_NO_DEREF msg refs/heads/badname" &&
248
git update-ref -d refs/heads/badname >output 2>error &&
249
test_path_is_missing .git/refs/heads/broken...ref &&