git_config_set_multivar_in_file: all non-zero returns are errors
This function is just a thin wrapper for the "_gently" form of the function. But the gently form is designed to feed builtin/config.c, which passes our return code directly to its exit status, and thus uses positive error values for some cases. We check only negative values, meaning we would fail to die in some cases (e.g., a malformed key). This may or may not be triggerable in practice; we tend to use this non-gentle form only when setting internal variables, which would not have malformed keys. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Apr 9, 2016 at 13:42 UTC
9c14bb08a434570adc9b2f0f37eac66b92d4c87e
1 file changed
+1
-1
config.c
+1
-1
@@ -2222,7 +2222,7 @@ void git_config_set_multivar_in_file(const char *config_filename,
2222
const char *value_regex, int multi_replace)
2223
{
2224
if (git_config_set_multivar_in_file_gently(config_filename, key, value,
2225
- value_regex, multi_replace) < 0)
2225
+ value_regex, multi_replace))
2226
die(_("could not set '%s' to '%s'"), key, value);
2227
}
2228