ref-filter.c: rename 'ref_filter_handler()' to 'filter_one()'
Rename 'ref_filter_handler()' to 'filter_one()' to more clearly distinguish it from other ref filtering callbacks that will be added in later patches. The "*_one()" naming convention is common throughout the codebase for iteration callbacks. Signed-off-by: Victoria Dye <vdye@github.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Victoria Dye committed
Nov 14, 2023 at 19:53 UTC
9c575b020232c5af0d2068aa82ce390923b81646
1 file changed
+6
-6
ref-filter.c
+6
-6
@@ -2686,7 +2686,7 @@ struct ref_filter_cbdata {
2686
* A call-back given to for_each_ref(). Filter refs and keep them for
2687
* later object processing.
2688
*/
2689
-static int ref_filter_handler(const char *refname, const struct object_id *oid, int flag, void *cb_data)
2689
+static int filter_one(const char *refname, const struct object_id *oid, int flag, void *cb_data)
2690
{
2691
struct ref_filter_cbdata *ref_cbdata = cb_data;
2692
struct ref_filter *filter = ref_cbdata->filter;
@@ -2917,15 +2917,15 @@ int filter_refs(struct ref_array *array, struct ref_filter *filter, unsigned int
2917
* of filter_ref_kind().
2918
*/
2919
if (filter->kind == FILTER_REFS_BRANCHES)
2920
- ret = for_each_fullref_in("refs/heads/", ref_filter_handler, &ref_cbdata);
2920
+ ret = for_each_fullref_in("refs/heads/", filter_one, &ref_cbdata);
2921
else if (filter->kind == FILTER_REFS_REMOTES)
2922
- ret = for_each_fullref_in("refs/remotes/", ref_filter_handler, &ref_cbdata);
2922
+ ret = for_each_fullref_in("refs/remotes/", filter_one, &ref_cbdata);
2923
else if (filter->kind == FILTER_REFS_TAGS)
2924
- ret = for_each_fullref_in("refs/tags/", ref_filter_handler, &ref_cbdata);
2924
+ ret = for_each_fullref_in("refs/tags/", filter_one, &ref_cbdata);
2925
else if (filter->kind & FILTER_REFS_ALL)
2926
- ret = for_each_fullref_in_pattern(filter, ref_filter_handler, &ref_cbdata);
2926
+ ret = for_each_fullref_in_pattern(filter, filter_one, &ref_cbdata);
2927
if (!ret && (filter->kind & FILTER_REFS_DETACHED_HEAD))
2928
- head_ref(ref_filter_handler, &ref_cbdata);
2928
+ head_ref(filter_one, &ref_cbdata);
2929
}
2930
2931
clear_contains_cache(&filter->internal.contains_cache);