config: avoid calling `labs()` on too-large data type
The `labs()` function operates, as the initial `l` suggests, on `long` parameters. However, in `config.c` we tried to use it on values of type `intmax_t`. This problem was found by GCC v9.x. To fix it, let's just "unroll" the function (i.e. negate the value if it is negative). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Schindelin committed
Jun 13, 2019 at 04:49 UTC
9dae4fe79f85dd0eaf41215bea76c68b65398fbc
1 file changed
+2
-2
config.c
+2
-2
@@ -869,9 +869,9 @@ static int git_parse_signed(const char *value, intmax_t *ret, intmax_t max)
869
errno = EINVAL;
870
return 0;
871
}
872
- uval = labs(val);
872
+ uval = val < 0 ? -val : val;
873
uval *= factor;
874
- if (uval > max || labs(val) > uval) {
874
+ if (uval > max || (val < 0 ? -val : val) > uval) {
875
errno = ERANGE;
876
return 0;
877
}